On Nov 4, 2016, at 10:50AM, Rainer Müller <rai...@macports.org> wrote:
> On 2016-11-04 18:10, Ivan Larionov wrote: > >> * Ability to get a feedback / review from other project members. >> >> We use private github setup on my work and we have a rule that you >> shouldn't commit directly to master in a project with multiple >> contributors until it's very small change like fixing typo. Open PR, >> ask for review, merge. Or fix issues and merge if you got any useful >> comments on PR. > > Who would be better to review the change then the maintainers of ports > themselves? I feel like this would unnecessary slow down the process of > getting the update out. > > Rainer In the past, I have seen responses to svn changelogs directed to the committer and copied to the dev list, so apparently port maintainers who are committers are not always the best reviewers. How many times has there been a post-svn-commit debate about whether something warranted a revision bump? I would recommend that any change that changes the build more than a version and checksum change warrants a pull request. If no one acts to review it within the timeliness dictated of the committer, then they still have the prerogative and authority to commit the changes when they want. My two cents. -Sterling _______________________________________________ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
