Hi, In view of some valuable suggestions concerning the alignment, I've updated the PR concerning update of port ehcache. I've corrected the spacing and alignment with appropriate whitespaces. The original portfile had tabs, and that misguided me to continue with the same.
May kindly validate the final commit, so that I may rebase the commits with the right message and you may merge the same. Any suggestions/recommendations are again thoroughly welcome and appreciated. Link to the file: https://github.com/macports/macports-ports/pull/6784/files . P.S.: If I'm undesirably spamming all of you, I'm sincerely apologetic about it. May please let me know if I should mail these to some specific recipients instead of the mailing list. Thanks and Regards, Yours Sincerely, *Saptarshi Mukherjee,* *A GSoC 2020 Aspirant.* On Mon, Apr 6, 2020 at 9:43 PM SAPTARSHI MUKHERJEE < [email protected]> wrote: > Hi, > > Warmest thanks again to Ryan Sir and Jackson Sir for their valuable > suggestions. The current PR seems to have met the requirements > appropriately. The pinpointed guidance by Ryan Sir was surely instrumental > in improving my understanding of many aspects of the ports' functioning. > > May please review my PR and provide necessary feedback, and if found > alright, may please merge the same. I'll indeed be quite glad about it. The > link to the PR is > https://github.com/macports/macports-ports/pull/6784/commits. I've > rebased the commits for a better view. > > Thanks and Regards, > Yours Sincerely, > *Saptarshi Mukherjee,* > *A GSoC 2020 Aspirant**.* > > > On Mon, Apr 6, 2020 at 12:13 PM SAPTARSHI MUKHERJEE < > [email protected]> wrote: > >> Hi, >> >> Thanks to Ryan Sir and Jackson Sir for the suggestions. I tried to >> incorporate the "github.setup", but it seems it is wrongly searching for >> the file "ehcache3-3.8.1.jar" instead of "ehcache-3.8.1.jar", and hence >> failing to fetch the distfile. I tried correcting it using "name" set to >> ehcache, but it doesn't help. Following is the link to the log file: Link >> <https://paste.macports.org/04be27c2177c>. The link to the PR is >> https://github.com/macports/macports-ports/pull/6784/commits. Any >> directions for correcting the error is highly appreciated. Thanks in >> advance. >> >> With Warmest Regards, >> Yours Sincerely, >> *Saptarshi Mukherjee,* >> *A GSoC 2020 Aspirant.* >> >> >> On Sun, Apr 5, 2020 at 4:27 PM SAPTARSHI MUKHERJEE < >> [email protected]> wrote: >> >>> Hi Sir, >>> >>> Thanks again for the opportunity. I've made a final PR for the update of >>> port 3.8.1 that has successfully passed the checks. Following is the link >>> to the PR: https://github.com/macports/macports-ports/pull/6784/files. >>> >>> I'd hereby sincerely thank Ryan Sir for his assistance that has not only >>> played a crucial role in enabling me in completing this, but has also >>> improved my understanding of some parts of the codebase immensely. >>> >>> I've rebased the commits. May kindly review the same and provide >>> necessary feedback. If it seems right, may kindly merge the same. Thanks >>> again. >>> >>> With Warmest Regards, >>> Yours Sincerely, >>> *Saptarshi Mukherjee,* >>> *A GSoC 2020 Aspirant.* >>> >>
