Hi, Having made the changes as per suggestions, I'd like to draw your kindest attention to my PR and request you for reviewing the same. Link to the PR: https://github.com/macports/macports-ports/pull/6784.
With Warmest Regards, Yours Sincerely, *Saptarshi Mukherjee,* *A GSoC 2020 Aspirant.* On Tue, Apr 7, 2020 at 3:40 PM SAPTARSHI MUKHERJEE < [email protected]> wrote: > Thank you Sir. I'll keep them in mind. > > With Warmest Regards, > Yours Sincerely, > *Saptarshi Mukherjee,* > *A GSoC 2020 Aspirant.* > > > On Tue, Apr 7, 2020 at 2:39 PM Mojca Miklavec < > [email protected]> wrote: > >> On Tue, 7 Apr 2020 at 06:23, SAPTARSHI MUKHERJEE wrote: >> > >> > May kindly validate the final commit, so that I may rebase the commits >> with the right message and you may merge the same. >> >> Why do you wait to get approval before fixing "a known issue"? >> GitHub offers an "Approve" button that developers may click without >> leaving any further feedback, but this one cannot be clicked before >> the contribution is ready to be merged; it's worse, one could have >> clicked "Request changes" and then you'll be stuck with a red cross >> until that same person checks again. >> >> > P.S.: If I'm undesirably spamming all of you, I'm sincerely apologetic >> about it. May please let me know if I should mail these to some specific >> recipients instead of the mailing list. >> >> I would advise against mailing individual recipients unless it's >> really off-topic and you know whom to contact or when someone might >> have missed the email in the sea of other messages from the mailing >> list. >> >> Generally the communication for such issues would be kept on the >> GitHub inside a code review, but asking the mailing list for attention >> if you get stuck somewhere, or if nobody has responded for a couple >> days. >> >> At these circumstances when we asked you for contributions it's >> probably ideal to send one email when you have opened a new PR to >> avoid a too long delay in response. When people have provided feedback >> to you, they will likely get a notification when you change something >> almost immediately, and there's certainly no need to send multiple >> reminders per day with requests to check your changes. >> >> If you are bored while waiting for a response, start working on a >> different ticket :) >> >> Mojca >> >
