#626: 1546 does not compile in kernel tree 2.6.16.1x
----------------------------------------+-----------------------------------
Reporter: [EMAIL PROTECTED] | Owner:
Type: defect | Status: closed
Priority: major | Milestone:
Component: madwifi: 802.11 stack | Version:
Resolution: duplicate | Keywords:
Patch_attached: 0 |
----------------------------------------+-----------------------------------
Changes (by mrenzmann):
* resolution: => duplicate
* status: new => closed
Old description:
> {{{
> After fixing ticket #625, I tried to compile in the code using
> the following .config entries:
>
> #
> # Atheros 802.11(a/b/g) PCI/Cardbus support
> #
> CONFIG_ATHEROS=y
> CONFIG_ATHEROS_HAL=y
> CONFIG_ATHEROS_RATE=y
> CONFIG_NET80211=y
>
> [EMAIL PROTECTED] linux]# make bzImage
> CC drivers/net/wireless/_ath_hal/ah_osdep.o
> In file included from drivers/net/wireless/_ath_hal/../hal/ah.h:49,
> from drivers/net/wireless/_ath_hal/ah_osdep.c:58:
> drivers/net/wireless/_ath_hal/../hal/linux/ah_osdep.h:120:5: warning:
> "AH_BYTE_ORDER" is not defined
> drivers/net/wireless/_ath_hal/../hal/linux/ah_osdep.h:155:5: warning:
> "AH_BYTE_ORDER" is not defined
> cp drivers/net/wireless/_ath_hal/../hal/public/i386-elf.hal
> drivers/net/wireless/_ath_hal/hal.o
> LD drivers/net/wireless/_ath_hal/ath_hal.o
> LD drivers/net/wireless/_ath_hal/built-in.o
> CC drivers/net/wireless/_ath_rate/onoe.o
> In file included from drivers/net/wireless/_ath_rate/../hal/ah.h:49,
> from
> drivers/net/wireless/_ath_rate/../ath/if_athvar.h:45,
> from drivers/net/wireless/_ath_rate/onoe.c:61:
> drivers/net/wireless/_ath_rate/../hal/linux/ah_osdep.h:120:5: warning:
> "AH_BYTE_ORDER" is not defined
> drivers/net/wireless/_ath_rate/../hal/linux/ah_osdep.h:155:5: warning:
> "AH_BYTE_ORDER" is not defined
> LD drivers/net/wireless/_ath_rate/ath_rate_onoe.o
> LD drivers/net/wireless/_ath_rate/built-in.o
> CC drivers/net/wireless/ath/if_ath.o
> In file included from drivers/net/wireless/ath/../hal/ah.h:49,
> from drivers/net/wireless/ath/../ath/if_athvar.h:45,
> from
> drivers/net/wireless/ath/../net80211/ieee80211_monitor.h:45,
> from drivers/net/wireless/ath/if_ath.c:69:
> drivers/net/wireless/ath/../hal/linux/ah_osdep.h:120:5: warning:
> "AH_BYTE_ORDER" is not defined
> drivers/net/wireless/ath/../hal/linux/ah_osdep.h:155:5: warning:
> "AH_BYTE_ORDER" is not defined
> drivers/net/wireless/ath/if_ath.c:4741:5: warning: "ATH_SUPERG_XR" is not
> defined
> CC drivers/net/wireless/ath/if_ath_pci.o
> In file included from drivers/net/wireless/ath/../hal/ah.h:49,
> from drivers/net/wireless/ath/if_athvar.h:45,
> from drivers/net/wireless/ath/if_ath_pci.c:61:
> drivers/net/wireless/ath/../hal/linux/ah_osdep.h:120:5: warning:
> "AH_BYTE_ORDER" is not defined
> drivers/net/wireless/ath/../hal/linux/ah_osdep.h:155:5: warning:
> "AH_BYTE_ORDER" is not defined
> LD drivers/net/wireless/ath/ath_pci.o
> LD drivers/net/wireless/ath/built-in.o
> CC drivers/net/wireless/net80211/if_media.o
> CC drivers/net/wireless/net80211/ieee80211.o
> CC drivers/net/wireless/net80211/ieee80211_beacon.o
> CC drivers/net/wireless/net80211/ieee80211_crypto.o
> CC drivers/net/wireless/net80211/ieee80211_crypto_none.o
> CC drivers/net/wireless/net80211/ieee80211_input.o
> CC drivers/net/wireless/net80211/ieee80211_node.o
> CC drivers/net/wireless/net80211/ieee80211_output.o
> In file included from
> drivers/net/wireless/net80211/../net80211/ieee80211_monitor.h:45,
> from
> drivers/net/wireless/net80211/ieee80211_output.c:55:
> drivers/net/wireless/net80211/../ath/if_athvar.h:45:16: error: ah.h: No
> such file or directory
> In file included from
> drivers/net/wireless/net80211/../net80211/ieee80211_monitor.h:45,
> from
> drivers/net/wireless/net80211/ieee80211_output.c:55:
> drivers/net/wireless/net80211/../ath/if_athvar.h:282: error: expected
> specifier-qualifier-list before 'HAL_NODE_STATS'
> drivers/net/wireless/net80211/../ath/if_athvar.h:521: error: expected
> ':', ',', ';', '}' or '__attribute__' before '*' token
> make[4]: *** [drivers/net/wireless/net80211/ieee80211_output.o] Error 1
> make[3]: *** [drivers/net/wireless/net80211] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> This seems to help somewhat, but I've no idea how it might affect those
> building modules, etc:
>
> diff -urN madwifi-ng-r1546-20060511/ath/if_athvar.h
> madwifi/ath/if_athvar.h
> --- madwifi-ng-r1546-20060511/ath/if_athvar.h 2006-04-21
> 12:57:59.000000000 -0400
> +++ madwifi/ath/if_athvar.h 2006-05-16 15:25:03.000000000 -0400
> @@ -42,7 +42,7 @@
> #ifndef _DEV_ATH_ATHVAR_H
> #define _DEV_ATH_ATHVAR_H
>
> -#include "ah.h"
> +#include "hal/ah.h"
> #include "if_athioctl.h"
> #include "net80211/ieee80211.h" /* XXX for WME_NUM_AC */
>
> diff -urN madwifi-ng-r1546-20060511/hal/ah.h madwifi/hal/ah.h
> --- madwifi-ng-r1546-20060511/hal/ah.h 2006-02-11 07:04:39.000000000
> -0500
> +++ madwifi/hal/ah.h 2006-05-16 15:25:30.000000000 -0400
> @@ -46,7 +46,7 @@
> * follow must call back into the HAL through interface, supplying the
> * reference as the first parameter.
> */
> -#include "ah_osdep.h"
> +#include "linux/ah_osdep.h"
>
> /*
> * __ahdecl is analogous to _cdecl; it defines the calling
>
> I do that BEFORE I run the install.sh script. Note that I still get the
> AH_BYTE_ORDER warnings but the interface works and transmits data so the
> default is clearly AH_LITTLE_ENDIAN, :) Still rather annoying during an
> otherwise clean kernel compile though.
> }}}
New description:
{{{
After fixing ticket #625, I tried to compile in the code using
the following .config entries:
#
# Atheros 802.11(a/b/g) PCI/Cardbus support
#
CONFIG_ATHEROS=y
CONFIG_ATHEROS_HAL=y
CONFIG_ATHEROS_RATE=y
CONFIG_NET80211=y
[EMAIL PROTECTED] linux]# make bzImage
CC drivers/net/wireless/_ath_hal/ah_osdep.o
In file included from drivers/net/wireless/_ath_hal/../hal/ah.h:49,
from drivers/net/wireless/_ath_hal/ah_osdep.c:58:
drivers/net/wireless/_ath_hal/../hal/linux/ah_osdep.h:120:5: warning:
"AH_BYTE_ORDER" is not defined
drivers/net/wireless/_ath_hal/../hal/linux/ah_osdep.h:155:5: warning:
"AH_BYTE_ORDER" is not defined
cp drivers/net/wireless/_ath_hal/../hal/public/i386-elf.hal
drivers/net/wireless/_ath_hal/hal.o
LD drivers/net/wireless/_ath_hal/ath_hal.o
LD drivers/net/wireless/_ath_hal/built-in.o
CC drivers/net/wireless/_ath_rate/onoe.o
In file included from drivers/net/wireless/_ath_rate/../hal/ah.h:49,
from
drivers/net/wireless/_ath_rate/../ath/if_athvar.h:45,
from drivers/net/wireless/_ath_rate/onoe.c:61:
drivers/net/wireless/_ath_rate/../hal/linux/ah_osdep.h:120:5: warning:
"AH_BYTE_ORDER" is not defined
drivers/net/wireless/_ath_rate/../hal/linux/ah_osdep.h:155:5: warning:
"AH_BYTE_ORDER" is not defined
LD drivers/net/wireless/_ath_rate/ath_rate_onoe.o
LD drivers/net/wireless/_ath_rate/built-in.o
CC drivers/net/wireless/ath/if_ath.o
In file included from drivers/net/wireless/ath/../hal/ah.h:49,
from drivers/net/wireless/ath/../ath/if_athvar.h:45,
from
drivers/net/wireless/ath/../net80211/ieee80211_monitor.h:45,
from drivers/net/wireless/ath/if_ath.c:69:
drivers/net/wireless/ath/../hal/linux/ah_osdep.h:120:5: warning:
"AH_BYTE_ORDER" is not defined
drivers/net/wireless/ath/../hal/linux/ah_osdep.h:155:5: warning:
"AH_BYTE_ORDER" is not defined
drivers/net/wireless/ath/if_ath.c:4741:5: warning: "ATH_SUPERG_XR" is not
defined
CC drivers/net/wireless/ath/if_ath_pci.o
In file included from drivers/net/wireless/ath/../hal/ah.h:49,
from drivers/net/wireless/ath/if_athvar.h:45,
from drivers/net/wireless/ath/if_ath_pci.c:61:
drivers/net/wireless/ath/../hal/linux/ah_osdep.h:120:5: warning:
"AH_BYTE_ORDER" is not defined
drivers/net/wireless/ath/../hal/linux/ah_osdep.h:155:5: warning:
"AH_BYTE_ORDER" is not defined
LD drivers/net/wireless/ath/ath_pci.o
LD drivers/net/wireless/ath/built-in.o
CC drivers/net/wireless/net80211/if_media.o
CC drivers/net/wireless/net80211/ieee80211.o
CC drivers/net/wireless/net80211/ieee80211_beacon.o
CC drivers/net/wireless/net80211/ieee80211_crypto.o
CC drivers/net/wireless/net80211/ieee80211_crypto_none.o
CC drivers/net/wireless/net80211/ieee80211_input.o
CC drivers/net/wireless/net80211/ieee80211_node.o
CC drivers/net/wireless/net80211/ieee80211_output.o
In file included from
drivers/net/wireless/net80211/../net80211/ieee80211_monitor.h:45,
from drivers/net/wireless/net80211/ieee80211_output.c:55:
drivers/net/wireless/net80211/../ath/if_athvar.h:45:16: error: ah.h: No
such file or directory
In file included from
drivers/net/wireless/net80211/../net80211/ieee80211_monitor.h:45,
from drivers/net/wireless/net80211/ieee80211_output.c:55:
drivers/net/wireless/net80211/../ath/if_athvar.h:282: error: expected
specifier-qualifier-list before 'HAL_NODE_STATS'
drivers/net/wireless/net80211/../ath/if_athvar.h:521: error: expected ':',
',', ';', '}' or '__attribute__' before '*' token
make[4]: *** [drivers/net/wireless/net80211/ieee80211_output.o] Error 1
make[3]: *** [drivers/net/wireless/net80211] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
This seems to help somewhat, but I've no idea how it might affect those
building modules, etc:
diff -urN madwifi-ng-r1546-20060511/ath/if_athvar.h
madwifi/ath/if_athvar.h
--- madwifi-ng-r1546-20060511/ath/if_athvar.h 2006-04-21
12:57:59.000000000 -0400
+++ madwifi/ath/if_athvar.h 2006-05-16 15:25:03.000000000 -0400
@@ -42,7 +42,7 @@
#ifndef _DEV_ATH_ATHVAR_H
#define _DEV_ATH_ATHVAR_H
-#include "ah.h"
+#include "hal/ah.h"
#include "if_athioctl.h"
#include "net80211/ieee80211.h" /* XXX for WME_NUM_AC */
diff -urN madwifi-ng-r1546-20060511/hal/ah.h madwifi/hal/ah.h
--- madwifi-ng-r1546-20060511/hal/ah.h 2006-02-11 07:04:39.000000000
-0500
+++ madwifi/hal/ah.h 2006-05-16 15:25:30.000000000 -0400
@@ -46,7 +46,7 @@
* follow must call back into the HAL through interface, supplying the
* reference as the first parameter.
*/
-#include "ah_osdep.h"
+#include "linux/ah_osdep.h"
/*
* __ahdecl is analogous to _cdecl; it defines the calling
I do that BEFORE I run the install.sh script. Note that I still get the
AH_BYTE_ORDER warnings but the interface works and transmits data so the
default is clearly AH_LITTLE_ENDIAN, :) Still rather annoying during an
otherwise clean kernel compile though.
}}}
Comment:
Please repost this as comment to #625 rather than opening a new ticket.
This way the problem and the solution are on the same page, making it much
easier to keep track of what happened in that regard.
In addition I'd ask you to put your patch in a file, attach that file to
#625 and [wiki:DevDocs/SigningPatches sign it off]. This makes handling
the patch easier, and being signed off is a requirement for a patch to be
committed to the repository.
Thanks for your support.
--
Ticket URL: <http://madwifi.org/ticket/626>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
