#725: Last fix (Changeset 1657) by proski to ath/if_ath_pci.c does not compile
-------------------------------------+--------------------------------------
Reporter: [EMAIL PROTECTED] | Owner: mrenzmann
Type: defect | Status: assigned
Priority: major | Milestone: version 0.9.2
Component: madwifi: makefiles | Version: trunk
Resolution: | Keywords: compilation warning
Patch_attached: 1 |
-------------------------------------+--------------------------------------
Comment (by proski):
I think the patch is wrong. We are not supposed to return 1. Returning
negated errno would be more logical. Although it's rare that the suspend
function returns anything but zero, all the examples I could find in the
kernel return -errno:
sc1200_suspend() in drivers/ide/pci/sc1200.c can return -ENOMEM.
usb_hcd_pci_suspend() in drivers/usb/core/hcd-pci.c can return -EBUSY.
Returning 1 would be like "one device suspended" or something like that.
Besides, what kernel is that? Not checking the result of
pci_set_power_state() is so common, I cannot imagine anyone enforcing this
check without a good reason and a patch that takes care of such
invocations at least in some parts of the kernel.
--
Ticket URL: <http://madwifi.org/ticket/725>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets
