#725: Last fix (Changeset 1657) by proski to ath/if_ath_pci.c does not compile
-------------------------------------+--------------------------------------
      Reporter:  [EMAIL PROTECTED]        |       Owner:  mrenzmann          
          Type:  defect              |      Status:  assigned           
      Priority:  major               |   Milestone:  version 0.9.2      
     Component:  madwifi: makefiles  |     Version:  trunk              
    Resolution:                      |    Keywords:  compilation warning
Patch_attached:  1                   |  
-------------------------------------+--------------------------------------
Comment (by [EMAIL PROTECTED]):

 You are right. It's probably best to return the value returned by the
 call.

 {{{
 Index: if_ath_pci.c
 ===================================================================
 --- if_ath_pci.c        (revision 1687)
 +++ if_ath_pci.c        (working copy)
 @@ -265,9 +265,7 @@
         ath_suspend(dev);
         PCI_SAVE_STATE(pdev, ((struct ath_pci_softc
 *)dev->priv)->aps_pmstate);
         pci_disable_device(pdev);
 -       pci_set_power_state(pdev, PCI_D3hot);
 -
 -       return 0;
 +       return pci_set_power_state(pdev, PCI_D3hot);
  }

  static int
 }}}
 Signed-off-by: Szymon Chachulski <[EMAIL PROTECTED]>

 The kernel I used was 2.6.11-1.1369_FC4-i686, which has the "__must_check"
 for pci_set_power_state().

-- 
Ticket URL: <http://madwifi.org/ticket/725>
MadWifi <http://madwifi.org/>
Multiband Atheros Driver for Wireless Fidelity
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Madwifi-tickets mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/madwifi-tickets

Reply via email to