On 10.06.2011 02:56, Barry Jackson wrote: > I have been working on a package to install Skype current stable release > and now feel that it is ready for submission for approval. > > It has already been improved/corrected/adapted many times following > discussions on #mageia-mentoring where I have been given lots of help. > > The idea evolved here https://bugs.mageia.org/show_bug.cgi?id=154 > where the current version is available as an attachment. > https://bugs.mageia.org/attachment.cgi?id=551 > > It has been a challenge and I have learned a lot in working on this. :)
I didn't test it, but the problems I see now: 1. The MD5SUM isn't checked, IMO it should be. 2. On error you exit with "|| exit 1" but leave the files in /tmp, polluting it. 3. You cp files to %_datadir using a wildcard (*), but these files may not be removed on uninstallation as you only have filename lists for avatars/sounds/langs. While it may work now (I didn't test, I hope you did), this will cause unnoticed problems when the skype tarball contents change. 4. Provide the script/commandline used to create the filelist files. 5. Versionize the filelist files to make sure they are renegerated when the package is updated to a new version (avatars-%version.txt) 6. Your usage of /tmp seems unsafe security-wise. What if some user has created something under /tmp/skype-%version already? Instead use mktemp to create a temporary directory. 7. You never remove the tarball, and the tarball is not %ghost. Also BTW, here is a package of mine for gootleearth from 2006 that uses a similar system: http://www.zarb.org/cgi-bin/viewvc.cgi/plf/SPECS/non-free/googleearth/ No need to make it like that, just pointing it out in case there are some ideas you'd like to use. -- Anssi Hannula
