Hey, On Wednesday 24 March 2010 23:43:12 Hannu Koivisto wrote:
> define-derived-mode already sets up magit-show-branches-mode-map > and automatically uses it. Just rename and move your map > definition above the mode definition so that your data will be > used. Ah right, wasn't aware of that -- even though I read the doc for define-derived-mode. Will change accordingly. > This doesn't sound right, you talk about burying but you pass kill > argument to quit-view. True, probably because I found 'kill' to be marginally more useful to me. Will change to 'bury' to match the other functions in magit which only bury but don't kill. > Did you perhaps mean: > > (looking-at "^\\s *\\*?\\s *\\([^\\s ]+\\)") ? I hate Emacs Lisp's regex syntax. Really. Will change. > Emacs Lisp convention would be to use imperative form (Remove the > branch...) and have just the first sentence on the first line and > start the second sentence on the second line (works better with > apropos, for example). Ok. I simply fill-paragraph when writing docstrings so far, and that's the result. > magit-show-branches lists remote branches too but I think this fails > to remove them because for them you'd need to specify -r (and strip > (or maybe rather make magit--branch-name-at-point strip) "remotes/" > prefix). True, haven't implemented that yet. I also have some more ideas for useful functions for the branch list, but I haven't had time to implement them. > > (defun magit-show-branches () > > "Show all of the current branches in other-window." > > Did you perhaps mean "Show all branches..."? That's not my docstring, that one was there before. > Just to let you know, there's `unless' for such (if (not ...) ...) > cases without an else branch. I know :) Regards, Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds To unsubscribe from this group, send email to magit+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
