Hey, On Wednesday 31 March 2010 00:21:00 Philip Jackson wrote:
> I've pushed a branch called fancy-branch-view in which I've done a > little bit of work in to see if I can bring the look-and-feel more in > line with the log view. > > As it's an extension of your work, can you let me know if you're happy > with its direction? The direction is fine -- I like having views consistent across magit. There are a couple of things I noticed, both when looking at the result and when looking at the code: 1. The branches list used to have an extra \n inserted at the end. Now it doesn't resulting in (point-max) being at the end of the last line of the last branch. I'd prefer if the last line was empty, also because the cursor ends up on (point-max) after each refresh making it more difficult for the eyes to track. Oh, and magit--branch-name-at-point breaks without that trailing \n because it uses (point-max) as an indicator for "on the last line where there is no branch". 2. Regarding the changes to magit-branch-name-from-line. Before it removed the "remotes/" prefix from the branch name before returning it. Now it doesn't. This breaks removing remote branches on git versions that output remote branches in "git branch -va" like "remotes/remotename/branchname", e.g. git 1.6.3.3. With your change git will be called "git branch -r remotes/remotename/branchname" while it has to be called as "git branch -r remotename/branchname". It's probably best to fix this by making changing magit-remove-branch to remove the "remotes/" prefix from magit--branch-name-at-point. Or fix magit-branch-name-from-line again. I'm not sure which is better. Hmm. Probably the latter as "remotes/remotename/branchname" is not a valid object name for git in any case -- the "remotes/" prefix is just information for the user so that he can keep local and remote branches apart in "git branch -a". Regards, Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
signature.asc
Description: This is a digitally signed message part.
