At Sun, 19 Sep 2010 15:05:54 +0000, Ævar Arnfjörð Bjarmason wrote: > > On Sun, Sep 19, 2010 at 14:46, Philip Jackson <[email protected]> wrote: > > At Sun, 19 Sep 2010 12:41:47 +0000, > > Ævar Arnfjörð Bjarmason wrote: > >> > >> It seems most of the activity is in master now, and master has > >> key-groups features, but my 5f680e44305ebc1e06905387976d413ae48d3f10 > >> patch in key-groups looks like it can't be cherry-picked either > >> because magit.el still uses the magit-commit-signoff variable, but I > >> don't think there's a need for it now that the master has the "-s" > >> signoff method. > > > > I've been creating local branches and hacking on them. > > > > You're patch was reverted along with my changes to log-edit. It seems > > people weren't happy with that aspect of the change. > > > >> Is testing of the key-groups branch still wanted, do some things > >> still need to be merged to master from there, or what? > > > > No, I'll delete it. I might as well push forward in master now. More > > eyes, and all that. > > I'm using master now (at 7658b557a0fdc4ad96d4c8dfcc6d5716aebab0b4) and > I don't get key-groups when I commit, and the old C-c C-s trick to do > signoffs still works.
That's expected, at the moment. The commit aspect of key groups needs more work/thought. Phil.
