David Abrahams <[email protected]> writes: > I often work on a project whose committers like to begin commit > messages with asterixes, which really makes the magit logs hard to > read. So I just went into magit-present-log-line and hacked in this > little phrase: > > (if (string-match "\\([^*]*\\)\\([*]\\)\\([^*]*\\)" graph) > (setq graph (concat (match-string 1 graph) "◉" (match-string 3 > graph)))) > > which replaces the asterixes in my graph with the unicode FISHEYE > character, which reads much better to my eye.
Nice! > I realize we can change magit-present-log-line-function, but I want to > keep most of the logic that's in there. I realize I could advise > magit-present-log-line, but this seems like it should be easier to do! > I think the graphs could get a *lot* better looking if I did some > other substitutions as well. So what about building in hooks for > log-line graph translation? The bulk size of the function is the mapconcat with its associated lambda. If the lambda is segregated as a proper function and hence made usable from the outside, magit-present-log-line becomes very small and then it doesn't look as a good candidate for being "hookified" anymore. Another thing to keep in mind is that some terminals do not support Unicode. Anyways, if you can provide more enhancements like the previous one, by all means go ahead. We will take care of cleaning the code, if necessary. > Thanks, > > Oh, BTW, Magit still rules. "still" ?
