At Tue, 16 Nov 2010 16:04:14 +0000, Marc Herbert wrote: > > Hi, > > It seems a missing --graph option is not supported any more. In other > words, (magit-configure-have-graph) cannot return nil any more > otherwise this breaks "oneline-re" and "wash-log". To demonstrate the > problem force to "nil" as shown below and then try open the (now > broken) log view. > > I see two possible fixes: > - fix the oneline-re regular expression, or > - make --graph a hard requirement and get rid of > (magit-configure-have-graph). > > I can try to implement either fix, please advise.
Well, to be frank there needs to be quite a lot of work around the log code. The long log doesn't work properly as it applies that RE to it. If you really want to fix the whole thing so that the log commands are a little more contextually aware and do the right thing when parsing, it would be a huge help. If you don't I'd say get rid of `magit-configure-have-graph' (unless people speak up and tell me they use it). Cheers, Phil
