At Wed, 17 Nov 2010 13:23:50 +0000, Marc Herbert wrote: > The (newer) "magit-log-oneline-re" regular expression was requiring > --graph, making the (older) magit-configure-have-graph logic > irrelevant: it had to return "true". Making --graph optional again is > not just fixing support for old git clients but also opening some log > possibilities, like removing the spurious star or showing tags in the > status view. > --- > > > Well, to be frank there needs to be quite a lot of work around the log > > code. The long log doesn't work properly as it applies that RE to it. > > > > If you really want to fix the whole thing so that the log commands are > > a little more contextually aware and do the right thing when parsing, > > it would be a huge help. If you don't I'd say get rid of > > `magit-configure-have-graph' (unless people speak up and tell me they > > use it). > > Well sorry *I* would like to speak up: I think making graph optional is > useful as explained in commit message above. And it is an easy and very > minor change, please review patch below.
Ok fine. Will apply. > PS: how often do you update github.com? What do you mean? Cheers, Phil
