At Wed, 01 Dec 2010 13:39:15 -0500, Dave Abrahams wrote: > As *huge* fans of magit, me and my colleagues are very concerned > about some of the recent changes. We're seeing lots of important > functionality broken (log all, snapshot, commit with amend...) and
Don't forget you're pulling from a bleeding-edge development repo. I don't remember commit with amend being broken. The --all bug (https://github.com/philjackson/magit/issues/issue/88) I pushed the fix literally minutes after you reported it. Snapshot is/was broken? > recent design decisions have been pushing many highly-useful > (formerly) single-keystroke commands into two-level pop-up buffers... We were simply running out of keys, really we had to do something to free some up. There was discussions, proof of concepts (which Óscar kindly did) and branches which I asked people to try out and comment on. Now isn't a great time to complain about them to be honest, having said that, there's still room for change if you can reason them well enough. The other problem is there's no test suite. There was talk on emacs-devel about including a framework officially (ert, I think) so we can write tests when that happens hopefully mitigating regressions. > So I guess we're just wondering what's happening, and if there's > anything we can do to influence the general direction. Code and discussion are two ways to influence development. I can see you've made several feature requests, that's fine but if you are willing to take the time to implement stuff you should as I'm far more likely to just merge it. > We've already made some contributions to magit and would be happy > to continue to do so, but don't want to waste our time trying to > counteract "bad commits." Aren't "bad commits" called "bugs" elsewhere? Why is fixing them a waste of your time? Is it a waste of mine? Cheers, Phil
