At Thu, 2 Dec 2010 16:11:42 -0500,
Dave Abrahams wrote:
> >> As *huge* fans of magit, me and my colleagues are very concerned
> >> about some of the recent changes. We're seeing lots of important
> >> functionality broken (log all, snapshot, commit with amend...) and
> >
> > Don't forget you're pulling from a bleeding-edge development repo.
>
> Good point. Is there a stable release tag we should be using to judge
> the state of things?
0.8.2 is the latest stable release. Of course judge the state of the
development branch but expect bugs.
> > I don't remember commit with amend being broken.
>
> It's broken from a design point-of-view, because there's no way to
> recover the old log message (unless it happens to be in the log
> message ringbuffer).
Which old message? The one of the commit you're amending? If so, it's
put in the buffer when you toggle amend. You would want it pushed into
the ring?
> > Snapshot is/was broken?
>
> * It doesn't save the index by default anymore. That's an alarming
> change.
You'll have to elaborate, if I stage a change and then stash, that
change is in the stash and comes out of it when I pop. It's
--keep-stash that's optional.
> * Furthermore, applying a stash doesn't restore the index even if it
> was saved.
Did that ever happen? I just tried it in 0.7 and it didn't restore the
index. Pickaxing through the log for '--index' shows nothing.
> We were giving a training on Magit yesterday and discovered the
> problems then, which was embarrassing because we'd been raving about
> how wonderful and game-changing Magit is.
I guess that's what happens when you don't rehearse /and/ you use
bleeding-edge software...
> >> recent design decisions have been pushing many highly-useful
> >> (formerly) single-keystroke commands into two-level pop-up buffers...
> >
> > We were simply running out of keys, really we had to do something to
> > free some up.
>
> Well, snapshot used to be on the `Z' key, which is now unbound.
So? We were still running out of keys.
> Logging has a billion options now, which is really nice from a
> flexibility point-of-view, but from a usability point-of-view it would
> have been much better (in our opinion) to keep the `l' binding for the
> usual shortlog case people do tens of times a day and require a prefix
> to pop up the grid of options for more unusual requirements.
> Personally I use the `log --all' option most and shortlog a little
> less, but I gather that pattern is not so common.
Yes, I like the prefix idea. Log is used enough to deseve that
shortcut. What do others here think?
[...]
> We have and will continue to submit patches.
[...]
> It's one thing to fix newly-introduced bugs, but it's something else
> to be trying to fight against the current. I guess we just want to
> make sure we're not swimming upstream.
To be frank David, I only see one commit from you. I don't know how
big your anonymous band of backers ("we") is but I get /far/ more
feature patches than I do bug patches. Nothing is free and so if you
really want to help and ensure you're pride remains intact when
demoing magit, why not make a start on the ert tests?
Cheers,
Phil
