At Mon, 06 Dec 2010 12:24:15 +0000, Marc Herbert wrote: > > Concerning which sub-option is more frequent I'd say let the git > command line decide and just be consistent with it.
As long as we don't carry that philosophy to extremes. One of Magit's greatest strengths is its ability to have a better default interface than plain git does. For example, "git push" with no arguments does some very undesirable things (one of our students pointed this out to us during our class). Also, it's great to have things like snapshot, which are composites of git commands, on a single key when they're really useful. > >>>> >> >> I am not sure the Ctrl-u prefix is the best key combination/user > >>>> >> >> interface ever but it is consistent with all other user interfaces > >>>> >> >> in > >>>> >> >> emacs and very flexible. > > >> > > C-u isn't consistent by nature. You could rarely make an assumption > >> > > about what a prefix arg will do to a command. > > All across emacs, C-u consistently enables the "less-frequent" > alternative(s) of a command. You are basically saying that the actual > meaning of "less-frequent" is often far from obvious. I agree but > this... > > - has nothing to do with consistency (how could magit > and... xcscope for instance be "consistent" with each other?) > - does not affect magit thanks to the interactive pop-up. Whatever else we do, having a `C-u to pop-up the options screen' convention makes magit's interface much more discoverable. If there is a second route to that option screen that doesn't involve C-u, so much the better. -- Dave Abrahams BoostPro Computing http://www.boostpro.com
