Le 05/04/2011 07:36, Steve Purcell a écrit : > Rémi Vanicat <[email protected]> writes: >> I've put your patch (with a typo removed) on github [1] (If you don't >> want to use github please, at least, include our patch in inlined text >> attachment, or directly in the email, it make discussion easier) > > Thanks Rémi -- I'll be sure to put any future patches on github > instead. > >> The idea seem cool, but people might object to change to the look and >> feel. Guys, what do you thinks about it ? >> >> [1] https://github.com/vanicat/magit/tree/inherit-face > > I'm also keen to hear others' thoughts. I personally think it's polite > for magit to use the user's preferred faces for diffs etc., and to also > inherit more general faces where possible. >
What would be even cooler than this patch is to top it up with a sample faces configuration spreading the *current* magit look all over Emacs. Like this you would not just make magit polite to new users, but also your change polite to existing magit users. As soon as they start complaining that you changed how everything looks you can immediately point them to a 10 seconds backward path to like it was before. You could also try to be even more polite, this time to the rare and weird users that want to keep EVERYTHING as before (and inconsistent), and contrib a sample, magit-specific faces config that returns only magit to its previous (=current) state. Just trying to maximise your pull chances :-)
