Marc Herbert <[email protected]> writes: > Le 08/04/2011 12:45, Steve Purcell a écrit : >> So you're worried that you might not like Emacs' standard diff colours > > Yes, and I might not be the only one. > >> If that's a problem for you, I'll happily provide a bunch of face >> definitions so that you can keep the magit faces exactly the same as before. > > Yes, I would find great to customize my entire Emacs with the current > magit defaults.
Forgive me, but your argument seems to be that making magit use the built-in Emacs faces will just make it look as ugly as the rest of Emacs! :-) That's a clear case for installing or writing a color theme. > After your change, others might want to restore magit's look *only*. I > guess a (different) set of definitions could solve that as well. > > Either would quench a (different) set of people complaining you changed > magit's default appearance. Isn't it best that magit's appearance be consistent with Emacs' appearance, whether that be Emacs' default colors, or a theme the user has applied? Anyone who has ever written (or used) a colour theme will know the frustration of finding glaringly mismatched colours in certain modes (usually Gnus!), and the difficulty of overriding them. Whereas org-mode, which inherits standard faces, tends to look pretty decent with any theme. -Steve
