Pieter Praet <[email protected]> writes: > This should have been fixed in 74e40248, the day after 14fdc8dc was > merged in. > > Since you haven't filed a bug report, I presume the issue is resolved?
I don't file bug reports, I fix bugs, and since I was able to get rid of the problem by reverting both 2d29228a and 14fdc8dc, I'm concentrating on other regressions and bugs at the moment. Right now my understanding of the issue, mostly based on the commit messages, is that reverting 2d29228a and 14fdc8dc is a sufficient fix, but I have to investigate more before I make a pull request. I originally didn't consider this as a bug per se but an intentional, albeit misguided UI change. I don't see how 2d29228a could fix the problem (and it clearly doesn't), since it doesn't undo 14fdc8dc, which changes where the rewriting starts. Rewriting must start below the commit over which magit-rewrite-start is invoked, otherwise you can't directly include the first unpushed commit in the commits to be rewritten. -- Hannu
