Eric Schulte <[email protected]> writes: >> Why not have `c' open the commit buffer directly, and `c' with a prefix >> argument (i.e. `C-u c') could open up the full option menu. In fact I >> would recommend this as the default for *all* magit commands (dangerous >> commands would probably want to be wrapped in a y-or-n-p). >> >> This would be efficient and convenient, provide for internal consistency >> within magit and this would be consistent with how Emacs at large >> handles optional command customization. To new users who have used >> Emacs before this should be the obvious thing to try. >> >> If there is any interest I'd be happy to put together a patch, given >> magit's very nice meta-programmed action mechanisms it seems like it >> should be a small change... very easy to implement, attached. >> > > I'm happy to hear that something along these lines will be adopted. > > Having used my previous patch for an hour or so I'm finding this > prefix-argument tact matches very well with my own personal Emacs-warped > muscle memory. If it's useful I'm attaching an improved version of the > previous patch.
I strongly oppose this change. For committing 99% of the time you want what now is `c c' but for other commands (log, branch) it is common to use a command variant (actually, `b' is a gateway for a group of different commands.) Pressing `C-u b v' for entering the branch manager or `C-u l L' for Long Log is anything but efficient. The key-groups design already allowed for the "most common variant" by assigning it the same letter as the key-group trigger (`l l', `b b', etc.) This introduced a negligible delay in exchange for lots of flexibility and grow space. Seriously, I can't see what's so inefficient with pressing an extra `c' for committing. Two tenths of a second for an operation that culminates a task that typically takes a minimum of several minutes? C'mon! It is true that `c c' faced enough resistance to ditch it. But the whole key-groups feature faced that same resistance and it survived, simply because Magit was running out of keys and there was a nightmare of command-prefix tricks (uh!) for accessing just a few of the most common options (all the rest be damned, as well as their combinations.) It could be said that `c c' was reverted to plain `c' just because committing has no variants (as logging does) and the options for `git commit' were not popular enough. -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
