On Thu, Aug 29, 2013 at 10:13:31AM -0400, Tom Davis wrote: > [email protected] writes: > > On 27 August 2013 14:40, Phil Jackson <[email protected]> wrote: > >> Hey all, > >> > >> When I wrote the current menu-popup system in Magit I implemented > >> a popup for commiting just like the one that's been built > >> here. People were generally happy with the popup menus elsewhere > >> but I pulled it out of commit because there was so much > >> resistance. > >> > >> Before I quit Magit I had intended to keep the current workflow > >> but have a slightly nicer implementation of the > >> header-for-options system that served us reasonably well for all > >> this time. > >> > >> My two cents; I'm not sure I like the new way. I find the menu is > >> obstructive in this instance. > > > > Agreed Phil. The most common commit use case by far is surely "commit > > without needing any special options", so to always pop up a menu > > offering options is suboptimal for the majority of cases. Presumably > > this is why there was so much resistance when you first introduced it. > > Overall I'd call it a great addition despite the annoyance of having to > hit "c c" because, for the times when I *did* need options, I simply > couldn't use magit at all for that commit.
Why not? > There are definitely still > bugs (first line of commit message is in the wrong place, the commit > buffer doesn't close when the commit finishes, etc.) but all of these > are minor compared with the use cases enabled by the new commit > mechanism. Which new use cases? I guess there are some which I missed. But even so, that does not in itself justify introducing a popup menu, because surely the new use cases could have been added to the old style of interface? -- --- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
