Jonas Bernoulli <[email protected]> writes: >> The main problem is that Magit does this upon loading, without even >> being used. I think that's a bug and needs to be fixed. The `add-hook' >> call cited by Noam above should probably be in the `magit' function, not >> at the top level, but I don't know the right way. > > I do agree that having some functionality turned on by just loading > a library isn't good. But it is also how Magit has always done it, > I just made it do so by using a built-in mode instead of the broken > code Magit used before.
The code Magit used before you came in was not broken, AFAIK. People complained because reverting a significant number of files after an operation takes a lot of time. Then you changed that by disabling the revert, later changed it again to do something else, and now magit turns on auto-revert for *all* files on a git checkout, including those that are not versioned. Not to mention that enabling auto-revert when the library is loaded is quite blunt. So you ended removing the old method, which worked fine but was slow, and replaced it with the blunt method that is as slow, is forced on unversioned files and doesn't update the VC modeline info when you switch branches without touching the file. IMO we should take a long breadth here, determine what the feature is meant to do, what variations people are interested on, weight the trade-offs and *then* proceed with the implementation. [snip] -- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
