On Fri, Oct 23, 2015 at 11:51 AM, Jonas Bernoulli <[email protected]> wrote:
>
> Patrick Brinich-Langlois <[email protected]> writes:
>
>> When I run magit-blame on a buffer, it prompts me to save other
>> buffers (apparently, any unsaved buffer in the same Git
>> repository). I can see why it would be necessary to save the buffer
>> I'm blaming, but why is it necessary to save the others?
(It shouldn't be necessary to save the buffer too -- see
`git-blame-mode' (from the git contrib directory) that works fine with
unsaved modifications.)
>> I find this behavior annoying, since I often can't remember what
>> changes were made elsewhere and whether they are worth preserving.
+17
FWIW, this is weaker than the auto-reverting thing, but still, I don't
think that I know of any Emacs functionality that saves buffers without
specific user authorization or without explicit customization. (And
I've been around the emacs block for a while now, roughly since v18.)
IMO, this is such an important principle, that I think that it's bad
that the docstring recommends using `dontask'.
> [...]
> Finally you could redefine `magit-save-repository-buffers' to only save
> the current buffer, but again that would affect of code, which assumes
> every buffer that visits a file in the current repository. So you
> probably shouldn't do that either.
I can't parse the first sentence above: are you saying that there is
code that would break when buffers are *not* saved? In other words, is
there any code that will *break* when `magit-save-repository-buffers' is
set to nil, or when it's set to t and when asked I refuse to save some
buffer?
> And you probably don't have to anyway. This saving happens a lot
> (e.g. every time you refresh the status buffer using either "C-g" or
> from that buffer just "g" and you only just noticed this now,
Um, my understanding is that the default t value (of
`magit-save-repository-buffers') means that I'll be asked before some
buffer is saved. Are you saying that there are some buffers that can be
saved *without* such a question?
> which probably means that the saving is not something that leads to
> undesirable results in your case (except that it "happens to early").
(No! This is repeating the same auto-revert story... You should
*never* assume that having some feature around when people don't notice
it is any kind of justification for its validity!)
--
((x=>x(x))(x=>x(x))) Eli Barzilay:
http://barzilay.org/ Maze is Life!
--
You received this message because you are subscribed to the Google Groups
"magit" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
