On Sat, Oct 24, 2015 at 11:22 AM, Eli Barzilay <[email protected]> wrote: > On Sat, Oct 24, 2015 at 4:02 AM, Jonas Bernoulli <[email protected]> wrote: >>> (It shouldn't be necessary to save the buffer too -- see >>> `git-blame-mode' (from the git contrib directory) that works fine >>> with unsaved modifications.) >> >> The buffer has to be saved, or this might happen: >> [...] > > I gave `git-blame-mode' as an example which shows that it's very > possible to have a blame interface that doesn't require saving the > buffer. Independent of the fact that `magit-blame' breaks or not. > > (And the fact that `magit-blame' works fine with local uncommitted > changes makes me think that it should be easy to make it work with > unsaved buffers too.)
magit-blame passes a filename to git. I looked at the code for git-blame-mode, it looks like it sends the current buffer contents to git's stdin. It may be useful to adopt git-blame-mode's technique. (All the flaming is not useful, I hope we can have less of that.) -- You received this message because you are subscribed to the Google Groups "magit" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
