Ah, it was sorta buggy, if you did this:

1. Set up two auth instances that can take an external username
2. Assign a user to one of them, and give them an external username in that 
auth.
3. Save.
4. Now, go to the user's account settings page, and switch them to the other 
external auth

Expected Result: External username field on the page should be empty, because 
the user doesn't have an external username registered with this auth yet
Actual Result: The external username field on the page is NOT empty, but 
continues to show the external username for the first auth.

That's because the code didn't bother switching the field to blank, if
there was no username stored.

It's handy to have it populate the stored username from the author auth
automatically. But I think it's handier to tell users the truth, and
only show them data in that form field if there actually is
corresponding data in the auth_remote_user table. So I'll add this to my
patch also.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1160093

Title:
  Don't display a remote username on /admin/users/edit.php if no remote
  username exists

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Per default, Mahara displays the "Username for external
  authentication" on the user account admin page no matter whether the
  account has actually set a remoteuser value or not. This is confusing
  when you want to check if an auth instance works correctly because you
  will have to check the database (in 2 different places) or at least do
  a user report which pulls the remotuser value from the "correct" DB
  table.

  Mahara should only display a remoteuser if it really exists.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1160093/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to