Even with my latest commits, there's still a bug case on the user edit screen:
1. Set up two auth instances that can take an external username 2. Navigate to the account settings page for a user and set their external username with one of these auth instances 3. Now, change their auth setting to the other auth instance that takes an external username 4. Change their external username (for that second auth instance) to something else 5. Save. 6. Now, go back to the user's account settings page, and change their auth instance back to the first auth instance. Expected Result: It should show the external username you entered for that first auth instance Actual Result: It will show the external username you entered for the second auth instance What we'd need to do, in order to make this work properly, is pull the external usernames for all your auth instances, store them in Javascript, and pop them in and out as you switch amongst auth instances. The squishy part, is what if you've edited the external username field, then you switch to another auth instance, then switch back, all without saving? Should Javascript retain your (changed but not saved) username and bring it back? Or should it just toss out your unsaved changed external username when you switch auth instances? I kinda favor the latter, just because it's easier and therefore less error-prone, and this is a corner-case anyway. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1160093 Title: Don't display a remote username on /admin/users/edit.php if no remote username exists Status in Mahara ePortfolio: In Progress Bug description: Per default, Mahara displays the "Username for external authentication" on the user account admin page no matter whether the account has actually set a remoteuser value or not. This is confusing when you want to check if an auth instance works correctly because you will have to check the database (in 2 different places) or at least do a user report which pulls the remotuser value from the "correct" DB table. Mahara should only display a remoteuser if it really exists. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1160093/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
