Reviewed: https://reviews.mahara.org/2477 Committed: http://gitorious.org/mahara/mahara/commit/ac9e5527b3071447d6ee49ec2420f71f901dd167 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch: master
commit ac9e5527b3071447d6ee49ec2420f71f901dd167 Author: Aaron Wells <aar...@catalyst.net.nz> Date: Thu Sep 5 18:26:55 2013 +1200 Upgrade our ADODB driver from the long-obsolete mysql driver to the actively developed mysqli driver Bug 1187964: The biggest improvement is that the ADODB mysqli driver actually supports transactions! Change-Id: I8e55ea28cd6e6b8ed5c883646c1172d318af5554 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1187964 Title: Use adodb "mysqli" instead of "mysql" Status in Mahara ePortfolio: Fix Committed Bug description: Mahara is currently using the adodb "mysql" driver for MySQL connections. This is based on an older PHP library which is no longer in active development and lacks certain features, most notably transactions (see for instance https://mahara.org/interaction/forum/topic.php?id=5434 ). We should probably switch to the adodb "mysqli" driver, which is built on the newer mysqli PHP library and *does* support transactions. There are two ways we could go about this gracefully: 1. When a user supplies the string "mysql5" in their config.php file, we could silently interpret this to mean that they want to use the "mysqli" driver. (We could alternately provide some other way to indicate they want to use the older "mysql" library if we really want to support it.) 2. OR, we could show the admin a warning message after they upgrade/install, which tells them they should really change the "mysql5" in their config.php to "mysqli". I support option #1. Given that we only support mysql and postgres, there's no reason we shouldn't abstract away the connection between config.php and the name of the underlying adodb driver. (For that matter, we should probably change the recommended dbtypes from "mysql5" and "postgres8" to just "mysql" and "postgres"). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1187964/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
