Reviewed: https://reviews.mahara.org/2530 Committed: http://gitorious.org/mahara/mahara/commit/d88b94001ec9980536f278cadd5fe827e32f95cb Submitter: Aaron Wells ([email protected]) Branch: master
commit d88b94001ec9980536f278cadd5fe827e32f95cb Author: Aaron Wells <[email protected]> Date: Thu Sep 26 17:05:48 2013 +1200 Undoing changes to the ArtefactTypeResumeComposite class signature Bug 1103942: Resume attachments included two unnecessary changes to the ArtefactTypeResumeComposite class which will break dependent code. First, it added a new abstract function. This will cause any file that contains a subclass that hasn't implemented that abstract function to error out. So I'm providing a sensible default implementation instead of making the function abstract. Second, it adds a Pieform as the first parameter to ensure_composite() to make it print Pieform errors. New parameters should always be added as the last parameter to a function, with a default value, so that existing calls to the method will still work. Additionally, there's no need for the Pieforms logic to be in that call, since this function is often used in a non-Pieforms context. I've refactored out the need for that parameter. Change-Id: I48b1f2375def6ed6aafdac389fcbb120ad04d359 Signed-off-by: Aaron Wells <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1103942 Title: Allow uploading attachments to Resume composites Status in Mahara ePortfolio: Fix Committed Bug description: Add the option for users to upload attachments to each item of any of the Resume composites (Eduaction history, Employment history, Certifications, Books and Memberships). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1103942/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
