(3) seems the most robust - that would be my preference. sendjsonrequest() (mahara.js:202) seems to be used pretty much universally for AJAX requests but error callbacks aren't given most of the time. However, if an error callback is given it is called in pretty much any situation (XHR error, invalid JSON, JSON with an 'error' property, etc.)
I notice that function already uses displayMessage() to display errors in some circumstances, but there are quite a few when it relies on the error callback to display anything. It would be nice to replace the spinner with an error message, but a simple fix could be to modify that function so that that a message is displayed at the top of the screen whenever it encounters an error. It wouldn't make the spinner go away, but it would at least be an indicator that something went wrong. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1305352 Title: Ajax "loading" spinners go forever when request fails Status in Mahara ePortfolio: Confirmed Bug description: Users are always coming to us with problem descriptions that sound like this, "I uploaded something and the spinner kept loading forever," or, "I tried to install and it kept saying loading forever". The problem is that when we do stuff via ajax we put up a "loading" spinner until the request comes back. But, if the request fails, then the spinner never comes down and the user waits and waits and waits, and thinks that the problem is a timeout rather than a server back-end error. It would be good if we could come up with an across-the-board solution for this. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1305352/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
