Public bug reported:
The code that sends out comment notifications tries to merge two arrays,
representing the users who need to be notified because they "own" the
page, and the users who have the page on their watchlist. If there are
no "owner" users for a page, then this code fails because that variable
holds a boolean false instead of an array.
This only happens for public comments, because for private comments the
watchlist is ignored, so there's no need to try to merge the arrays.
To replicate:
1. Create a group
2. In the group's settings set "Feedback notifications" to "None"
3. Create a page in the group
4. Leave a public comment on the page
Expected result: Your public comment should be posted on the page
Actual result: The AJAX "processing" message comes up but never finishes, and
the comment doesn't post
** Affects: mahara
Importance: Undecided
Status: New
** Affects: mahara/15.10
Importance: Undecided
Status: New
** Affects: mahara/16.04
Importance: Undecided
Status: In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1509129
Title:
Crash when posting a public comment that no one will be notified about
Status in Mahara:
New
Status in Mahara 15.10 series:
New
Status in Mahara 16.04 series:
In Progress
Bug description:
The code that sends out comment notifications tries to merge two
arrays, representing the users who need to be notified because they
"own" the page, and the users who have the page on their watchlist. If
there are no "owner" users for a page, then this code fails because
that variable holds a boolean false instead of an array.
This only happens for public comments, because for private comments
the watchlist is ignored, so there's no need to try to merge the
arrays.
To replicate:
1. Create a group
2. In the group's settings set "Feedback notifications" to "None"
3. Create a page in the group
4. Leave a public comment on the page
Expected result: Your public comment should be posted on the page
Actual result: The AJAX "processing" message comes up but never finishes, and
the comment doesn't post
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1509129/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : [email protected]
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
