Reviewed: https://reviews.mahara.org/5607 Committed: https://git.nzoss.org.nz/mahara/mahara/commit/ac50614876cd059ec55a6096e34efb220a57a551 Submitter: Aaron Wells ([email protected]) Branch: 15.10_STABLE
commit ac50614876cd059ec55a6096e34efb220a57a551 Author: Aaron Wells <[email protected]> Date: Fri Oct 23 12:33:40 2015 +1300 Sometimes $this->users is boolean false, not an array Bug 1509129 Change-Id: I68e2731306ab231aa8f1421e12dc641184e5999b (cherry picked from commit baabb7e5ed7c7206c6de5d952bf0e4f630817690) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1509129 Title: Crash when posting a public comment that no one will be notified about Status in Mahara: Confirmed Status in Mahara 15.10 series: Confirmed Status in Mahara 16.04 series: In Progress Bug description: The code that sends out comment notifications tries to merge two arrays, representing the users who need to be notified because they "own" the page, and the users who have the page on their watchlist. If there are no "owner" users for a page, then this code fails because that variable holds a boolean false instead of an array. This only happens for public comments, because for private comments the watchlist is ignored, so there's no need to try to merge the arrays. To replicate: 1. Create a group 2. In the group's settings set "Feedback notifications" to "None" 3. Create a page in the group 4. Leave a public comment on the page Expected result: Your public comment should be posted on the page Actual result: The AJAX "processing" message comes up but never finishes, and the comment doesn't post To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1509129/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
