Reviewed: https://reviews.mahara.org/8577 Committed: https://git.mahara.org/mahara/mahara/commit/60d042fa7fd5d298920e5cac6d02729495008afc Submitter: Robert Lyon ([email protected]) Branch: 17.10_STABLE
commit 60d042fa7fd5d298920e5cac6d02729495008afc Author: Robert Lyon <[email protected]> Date: Fri Mar 2 09:11:41 2018 +1300 Bug 1752688: Need to check what flavour of mysql is being used Because MariaDB does not have JSON cast type but does have a higher version number than 5.7 behatnotneeded Change-Id: I5a66ddb8c382a68fde189b420088bb29ef06893c Signed-off-by: Robert Lyon <[email protected]> (cherry picked from commit ca22b51fa5a736d28c2ded3e6a523ca3eb5d3c0a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1752688 Title: MariaDB fails to upgrade - unable to CAST as JSON Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Bug description: There is a problem in htdocs/lib/db/upgrade.php on the line if (is_mysql() && version_compare($db_version, '5.7.8', '>=')) { The problem is Mahara recognises both MySQL and MariaDB as being is_mysql() and their numbering systems are different (where MariaDB is around 10.* while MySQL is around 5.*) While both are mostly compatible with each other there are some slight differences and in this case CAST as JSON is not yet available in MariaDB. In this case we need to check which type of is_mysql() we have and if it is not 'MySQL' then we need to return the if statement as false rather than true. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1752688/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
