Hi Kevin. Thank you very much for the patch. We will put it into our
code review system https://reviews.mahara.org Can you please send me
your email address so we can credit you as author?

If you like, you can put future changes and new features directly into
the code review system yourself:

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Wishlist

** Changed in: mahara
    Milestone: None => 18.10.0

** Summary changed:

- Can delete markers comments when work is submitted for marking
+ Comments can't be deleted when work is submitted for marking

You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!

  Comments can't be deleted when work is submitted for marking

Status in Mahara:
  In Progress

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:

Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to