Launchpad: https://bugs.launchpad.net/mahara/+bug/1763517
Gerrit: https://reviews.mahara.org/#/c/8810/
Bug description: Comments can't be deleted when work is submitted for marking
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome

===================
Acceptance Criteria: 

1. While work is locked, to hide the delete comment form for annotation 
comments (Smart evidence feedback) and to check if work is in a submitted state 
before deleting page comments. 
2. Users can still show/hide comments from public as needed
3. Creators of comments can still edit them (during the edit time frame), but 
will not be able to delete them while the page is under review
===================
Manual Test Script
===================

Preconditions:
1. User5 exists and is a member of Group 101 
2. Portfolio page exists as follows
        a. title = work submitted for Marking
        b. Allow comments = Yes 
        c. SHARED WITH = Public 
3. Group 101 exists
4. User6 has made 2 comments on User5's page "
work submitted for Marking"
6. User5 has made a comment on User5's page "work submitted for Marking"

Test Script:
1. log in as User5 
2. Browse to Main menu > Portfolio > Pages and collections - "work submitted 
for Marking"
3. Confirm that user cannot edit Page content ✔
4. Confirm that user can see the previous comments displayed ✔
5. Confirm that user can not see detele comment icon ✔
6. Log in as User6 and make a comment on  User5's page "work submitted for 
Marking"
7. Confirm that users can still make comments to work that has been submitted 
for Marking ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1763517

Title:
  Comments can't be deleted when work is submitted for marking

Status in Mahara:
  In Progress

Bug description:
  Version:  Mahara 18.04.0
  Os: Mac
  Database: mysql
  Browser: chrome: Version 65.0.3325.181 (Official Build) (64-bit)

  Issue:
  When work is submitted for Marking, all comments and feedback during the 
marking process can be deleted by the user.

  Possible solution:
  While work is locked, to hide the delete comment form for annotation comments 
(Smart evidence feedback) and to check if work is in a submitted state before 
deleting page comments.

  Users can still show/hide comments from public as needed. Creators of
  comments can still edit them (during the edit timeframe), but will not
  be able to delete them while the page is under review.

  Attached is a patch with this possible solution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1763517/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to     : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

Reply via email to