Reviewed: https://reviews.mahara.org/9017 Committed: https://git.mahara.org/mahara/mahara/commit/38f762ffe4d5250c038c2644fe1c46694f7b1e7e Submitter: Robert Lyon ([email protected]) Branch: master
commit 38f762ffe4d5250c038c2644fe1c46694f7b1e7e Author: Robert Lyon <[email protected]> Date: Tue Jul 17 16:38:12 2018 +1200 Bug 1782062: Make is_valid_url() timout faster if no connection behatnotneeded Change-Id: I2d8107d71f0bc08367081dc129d2bdb4ec31d68c Signed-off-by: Robert Lyon <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1782062 Title: Gravatar connection timeout too long Status in Mahara: Fix Committed Bug description: If you are using a site with gravatars enabled and they connection is not resolvable then on login the check is held open for 60 seconds until curl instance times out as per: curl_setopt($ch, CURLOPT_TIMEOUT, 60); in mahara_http_request() But the check goes thru is_valid_url() and this is because we don't want to fetch the result but check the url does exist/resolves So we should pass a CURLOPT_CONNECTTIMEOUT value that is small so things timeout much quicker To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1782062/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
