We tend to add icons for things via HTML markup, like so: <span class="icon icon-type icon-lg" role="presentation" aria-hidden="true"></span>
But for styles that are repeated throughout the site we should try and do things in a smarter way and have the font-awesome icons be added via css For example we add danger / success / info / warning messages, edit / delete / add buttons throughout the system and we need to add the <span> to all of them to get the icons showing in the messages. It would be better if we just harness the :before or :after css classes to add the icons - that way if we ever need to change / adjust the icons we only need to change it in one place and styles would be more consistent. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1835329 Title: Alert message are not displaying icons Status in Mahara: Confirmed Bug description: TITLE: Alert message are not displaying icons BUG SUMMARY: When encountering error message ie (trying to add a folder without first entering a name) The error message is missing the Icon ============================================== Environment tested: Master Browser tested: Chrome PRECONDITIONS: ------------------------ 1) n/a TEST STEPS: ------------------------ 1) User log in as Site admin 2) browse to the files upload page http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/artefact/file/index.php 3) Click the Create new folder button (Without entering a name in the field EXPECTED RESULT: An error message should be displayed ✔ However the error message does not display an Icon next to the text. This is needed as some people will not see colours ACTUAL RESULT: Error message displayed but no icons associated with error NOTE: This appears to be the same with other alert messages such as warnings, success and info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1835329/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
