Reviewed: https://reviews.mahara.org/10419 Committed: https://git.mahara.org/mahara/mahara/commit/cacded8474967744e0eee5e9a0197c51457247f3 Submitter: Robert Lyon ([email protected]) Branch: master
commit cacded8474967744e0eee5e9a0197c51457247f3 Author: Evonne <[email protected]> Date: Tue Oct 8 11:59:43 2019 +1300 Bug 1835329 Alert message icons Taken out spans within alert and put in icons in alert:before, added variation for site-messages so it can be shorter and hang with page breakpoints. Also added icons for error messages under form inputs. behatnotneeded Change-Id: Ia31af160808ecc2943bb16ba68f04e8a98c0e055 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1835329 Title: Alert message are not displaying icons Status in Mahara: Fix Committed Bug description: TITLE: Alert message are not displaying icons BUG SUMMARY: When encountering error message ie (trying to add a folder without first entering a name) The error message is missing the Icon ============================================== Environment tested: Master Browser tested: Chrome PRECONDITIONS: ------------------------ 1) n/a TEST STEPS: ------------------------ 1) User log in as Site admin 2) browse to the files upload page http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/artefact/file/index.php 3) Click the Create new folder button (Without entering a name in the field EXPECTED RESULT: An error message should be displayed ✔ However the error message does not display an Icon next to the text. This is needed as some people will not see colours ACTUAL RESULT: Error message displayed but no icons associated with error NOTE: This appears to be the same with other alert messages such as warnings, success and info To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1835329/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
