Reviewed: https://reviews.mahara.org/10061 Committed: https://git.mahara.org/mahara/mahara/commit/be7af61faa0f8cae4ccf72b53d29a10885ae1746 Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit be7af61faa0f8cae4ccf72b53d29a10885ae1746 Author: Lisa Seeto <[email protected]> Date: Thu May 30 11:07:14 2019 +1200 Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" create modal using configureblock id, update various templates to use the modal for blocks: Image Note File(s) to download Journal/blogs add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments. add JS to handle url that redirects to view/view.php with modal open and populated. Further changes to each block will be completed in child patches. Add segment headings to the modal. Fix display of comments to cover width of modal. Show comment removed msg in modal/page appropriately. Fix behat test to close modal before continuing. do not show existing comments if comments not allowed on artefact. add validation to modal for comments/attachments disable image as link when editing for image block trigger focus on modal for accessibility close modal on escape keydown event fix merge conflict in view/view.php fix merge conflict with master make configureblock modal play nicely when comment block is on the page update display of error messages to always show at top of modal so user doesn't have to scroll add accesibility to close modal on escape key down handle dock show/hide events for paginated pages in modal during validation create block-comments-details-header template file create details button and custom scss file with js to show and hide header update comment links to save add comment and details when commentcount == 0 add active-block class to colour the block-header when active toggle the details-btn active css add _block-comments-details-header.scss to patch change class invisble to class d-none add block-comments-details-header.tpl to blocktypecontainerviewing.tpl code review changes add .no-modal class to links on group home page, dashboard and profile page. add block header to appear above the title change assessbtn from anchor tag to button to prevent scrolling. make all clickable links clickable on page load (ignore assess mode) fix js issues surrounding assessbtn move and show/hide blocks change cursor on dashboard, my profile page, group homepage to default when over disabled modal links update assessbtn to details btn create tooltip for hover over file download block titles fix containerElm console log error by not reattaching tinymce unneccessarily. fix null named attributes issues on e.target when span (icons) instead of anchor is clicked. Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827811 Title: Move "Add comment" and "Details" into modal with "Comments" Status in Mahara: In Progress Bug description: This is part of the page revamp: https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision Currently, the "Add comment" and "Details" links at blocks that can have them, takes you to a separate page where you can view the artefact's metadata and can leave comments. When you view comments, they are already displayed in the modal directly on the page, but you can't leave a comment yet. The things to be done: - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link. - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up. This would also mean to review all the "Details" on blocks as some of them are not needed. For example, clicking the details link next to a plan task only shows that single plan task again without any additional details. The "Details" should only be there when there is additional metadata information but not simply repeating the block content. The title of the modal (the one in the green bar) would be the blocktype as the title of the block is listed below. A decision still needs to be made on whether comments can be paginated in the modal or if they are shown all one after another (which might get quite long). We are not changing anything else from the proposal as that requires Gridstack to be implemented first. This is a standalone usability improvement independent of Gridstack. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
