Reviewed: https://reviews.mahara.org/10304 Committed: https://git.mahara.org/mahara/mahara/commit/953a5eab46711322c071b7f4b25bf7431b14a4ed Submitter: Cecilia Vela Gurovic ([email protected]) Branch: master
commit 953a5eab46711322c071b7f4b25bf7431b14a4ed Author: Lisa Seeto <[email protected]> Date: Fri Sep 6 14:25:29 2019 +1200 Bug 1827811: Resume Icons - get attachment comment counts for bh icons - display plain text for titles in editing mode - change the way the commentlink is targetted via js - add blockid's to resume attachments - for folder block: add comment count, change titles from links to plain text when editing - change notes attachment file titles from links to plain text when editing - get rid of the single artefact block title links for html exports --------------------------------------------------------- Add fixes: - blocks that have set types but no artefacts attached don't have modal links - pdf block is now using block header and comment count is loaded - block headers are above titles - tagged journals have icons when in full and matches recent posts styling - deleting all comments produces correct icon on block header - html exports should not hang on opening modal - get rid of warning error re: dock.show() when redirecting from &modal=1 style url - code review fixes for all previous patches + fix issue with folders block - added in viewdetailsfilter.json.php file to save details mode to user account prefs table - make the details btn mode "sticky" so it stays the save value over multiple pages etc... - Image Gallery blocks: if displaying a folder of images will get the bar block header and will have a the fancy box image preview displaying on image click Change-Id: I425cc5a634e176d580aacdb60a20f869f7cb7496 Signed-off-by: Lisa Seeto <[email protected]> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827811 Title: Move "Add comment" and "Details" into modal with "Comments" Status in Mahara: In Progress Bug description: This is part of the page revamp: https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/Page_layout_revision Currently, the "Add comment" and "Details" links at blocks that can have them, takes you to a separate page where you can view the artefact's metadata and can leave comments. When you view comments, they are already displayed in the modal directly on the page, but you can't leave a comment yet. The things to be done: - Combine comments, add comment, Details to "Comments and details" (or just comments or just details depending on what can be displayed) so you only have one link. - Clicking that link opens up a modal on the page that shows the artefacts details (if there are any) and also the comments, as well as allows you to leave comments if that is enabled. Please see the attached mock-up. This would also mean to review all the "Details" on blocks as some of them are not needed. For example, clicking the details link next to a plan task only shows that single plan task again without any additional details. The "Details" should only be there when there is additional metadata information but not simply repeating the block content. The title of the modal (the one in the green bar) would be the blocktype as the title of the block is listed below. A decision still needs to be made on whether comments can be paginated in the modal or if they are shown all one after another (which might get quite long). We are not changing anything else from the proposal as that requires Gridstack to be implemented first. This is a standalone usability improvement independent of Gridstack. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827811/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : [email protected] Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
