Reviewed: https://reviews.mahara.org/10944 Committed: https://git.mahara.org/mahara/mahara/commit/3b963a092638878d5777c87c18bf7e9aab3a3741 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 3b963a092638878d5777c87c18bf7e9aab3a3741 Author: Cecilia Vela Gurovic <cecili...@catalyst.net.nz> Date: Wed Apr 29 12:06:53 2020 +1200 Bug 1874540: preventing filelist buttons to catch events from the form that contains them To reproduce in Resume section - go to Create-> Resume-> Education and employment - add one Education history - set all required fields and then click on the 'Save' button - edit the same Education history - add a file with the filechooser - click on any other field and press 'Enter' result: the form is not submitted but one of the files is removed from the filelist behatnotneeded Change-Id: Ib2361b62b20bfc1beb80709aafa95684b1b2ce36 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1874540 Title: Page settings form not behaving as expected Status in Mahara: Fix Committed Bug description: Now that we have the cover image chooser on the form when I go to make a new page and press enter when focus is on page title field the form doesn't save Instead there is an 'quotaUpdate( undefined undefined ) called but no id="quota_fill" on page' warning in the console log. And if I open the Advanced section and go into the 'Add a file' I see the error message 'The file / folder name is required.' Also if I select a cover image and save the form with the 'save' button and then come back to edit settings and update the page title and hit save - again the form doesn't save but now the selected cover image is now unselected - which will be confusing as the advanced section is still hidden. So somehow, the 'enter' keystroke is being captured by the file chooser even when we are not focussed on it. If we are not focusssed on the 'add a file' button or the 'remove' button for the selected cover image then they should not capture the enter keystroke To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1874540/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
