I committed the change described in this thread. Yeah I think the separate representations still make sense, I think I had a momentary lapse of reason there.
On Fri, Feb 12, 2010 at 11:48 AM, Jeff Eastman <j...@windwardsolutions.com> wrote: > +1 to all of Drew's comments > > Drew Farris wrote: >> >> +1 to eliminating the statics, they are indeed evil. The type to read >> should be stored in the thing doing/facilitating the reading not the >> vector itself and definitely not in a static field. Pretty sure vector >> shouldn't be facilitating the reading of itself. No need for >> synchronization then. The static methods should go away. >> >> +1 to different sparse/dense on disk representations. I don't want to >> write a mostly empty 12000 element array if I have a cardinality of >> 12000 but only 30 values in each of my vectors. Likewise, I don't want >> to write indexes for 5000 values if my cardinality is 5200. >> >> +1 to eliminating class names in serializations (this is especially >> bad when an efficiently managed enum can do the job) >
