On Mon, Feb 15, 2010 at 12:45 AM, Sean Owen <sro...@gmail.com> wrote:
> I looked at the result and it seems a fair bit more happened. I don't > mind line rewrapping in javadoc, or putting newlines after <p>, though > I do tend to think those are noise changes not worth applying. > > I don't know if we ever talked about minor stuff like, do java.* imports go first or last. But we seemed to have had a convention going, and every file got reversed. That doesn't seem worthwhile. These are part of the Lucene Code formatter. Taken from the Lucene wiki. Mahout version just cleans up method definitions but sticks to the lucene version. > > But why are all static references qualified now? like, all "log" lines > are now "MyClass.log(...)" That doesn't seem right to me at all. Lots > of code is less readable and running well over 120 columns. > > return 2.0 * (LogLikelihoodSimilarity.logL(k1 / n1, k1, n1) > + LogLikelihoodSimilarity.logL(k2 / n2, k2, n2) - > LogLikelihoodSimilarity.logL(p, k1, n1) - LogLikelihoodSimilarity > .logL(p, k2, n2)); > > > This. I am looking. Can be an easier fix than rolling back. > > I'd propose a rollback just for the last item -- I can't deal with > that one myself. Then briefly discuss the rest of the changes that > happened and whether there's consensus. Then hit it again. I do like > standardization. > Take a look at the checkstyle too. If we make that as the target standardization, then there wont be any issue going forward. If checkstyle says ok, the code should be ok. On Sat, Feb 13, 2010 at 2:55 PM, Robin Anil <robin.a...@gmail.com> wrote: > > I just did a mass code cleanup. > > > > Mainly comprising of > > -Extra blank line removal > > -Organize Imports across all packages. > > -Making local variables final > > > > No reordering of methods or code style changes are applied. > > > > Any objections or any particular class to withhold from committing. > > > > Robin > > >
