> > I don't object to good style. I object to sweeping changes that break a lot > of patches. Maybe not the case here, but it will be in the future and unless > the whole thing is automated as part of committing (as Hadoop does), the code > will always have formatting issues causing this exact same thing to happen. > I've lived it on Lucene for a lot of years and you can see the debate in the > archives.
That's why I push putting into the maven build, eclipse, etc. You don't really need a commit hook if you have that. > >> I give up on it though. All I particularly care about is >> the static-initializer thing, and people not complaining about me >> doing small code cleanup. > > I don't have a problem w/ small code cleanup, but that isn't the subject of > this message. I usually reformat the files affected when I commit. IntelliJ > even has this built into it's commit capabilities and I'm all for it. > >> >> On Sun, Feb 14, 2010 at 10:07 PM, Grant Ingersoll <gsing...@apache.org> >> wrote: >>> If ever there were a case of >>> http://en.wikipedia.org/wiki/Parkinson's_Law_of_Triviality, this is it. >>> Committer time is a scarce resource. Unless it's automated, the code will >>> always drift out of format. I'd rather be able to cleanly apply a patch >>> than worry about a particular style being applied. We can apply the >>> styling when committing. >>> >>> -Grant >>> >>> > > >
