-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Barry Warsaw wrote: > On Oct 4, 2007, at 9:46 PM, [EMAIL PROTECTED] wrote: > >> ------------------------------------------------------------ >> revno: 992 >> committer: Mark Sapiro <[EMAIL PROTECTED]> >> branch nick: 2.1 >> timestamp: Thu 2007-10-04 18:35:10 -0700 >> message: >> /cygdrive/c/MM_bzr/log.txt >> modified: >> Mailman/versions.py > >> === modified file 'Mailman/versions.py' >> --- a/Mailman/versions.py 2005-12-30 18:50:08 +0000 >> +++ b/Mailman/versions.py 2007-10-05 01:35:10 +0000 >> @@ -483,10 +483,11 @@ >> # blow away the original timestamp and request id. >> This means the >> # request will live a little longer than it possibly >> should have, >> # but that's no big deal. >> + import email >> for p in v: >> author, text = p[2] >> reason = p[3] >> - msg = Message.OutgoingMessage(text) >> + msg = email.message_from_string(text, >> Message.Message) >> l.HoldMessage(msg, reason) >> del r[k] >> elif k == 'add_member': > > Should the import happen at the module global level?
I thought about that. Our standards of course say yes, but this particular import only occurs when updating a Mailman 1.0.x list which I hope happens very infrequently. However I don't really feel strongly either way. - -- Mark Sapiro <[EMAIL PROTECTED]> The highway is for gamblers, San Francisco Bay Area, California better use your sense - B. Dylan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) iD8DBQFHQQU/VVuXXpU7hpMRAgKkAKDu+323UJuX81GEFrykXkh+SfxdNgCgx0Sy YtFAMJL5vdUfNV538VNl0uY= =aqO7 -----END PGP SIGNATURE----- _______________________________________________ Mailman-checkins mailing list Mailman-checkins@python.org Unsubscribe: http://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
