-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Nov 19, 2007, at 12:14 PM, Mark Sapiro wrote:
> Barry Warsaw wrote: >> On Nov 18, 2007, at 10:38 PM, Mark Sapiro wrote: >> >>> I thought about that. Our standards of course say yes, but this >>> particular import only occurs when updating a Mailman 1.0.x list >>> which I >>> hope happens very infrequently. However I don't really feel strongly >>> either way. >> >> Ultimately it's a style issue. I'm nearly positive that it will >> make no >> significant different in performance. Generally I like to have >> function >> scope imports only when necessary (e.g. to avoid circular import >> problems). But I'll leave it up to you to change or not. > > > I've moved the email import, and also an import of _BounceInfo. I'm > ready to commit this, but I want to run it by you first to see if I'm > missing anything with regard to moving the import of _BounceInfo. Hi Mark, I think it should be fine, as long as it doesn't create a circular import. I didn't run the code, but from grepping it looks like we should be okay. The only import of Mailman.versions is at file scope afaict. - -Barry -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFHR4zG2YZpQepbvXERAut0AJ40NPdqbfI3Z+EQsLibny4atEGjLQCgkw20 JLr8bvq5WFV/O45Uo7JoCX8= =FfSi -----END PGP SIGNATURE----- _______________________________________________ Mailman-checkins mailing list Mailman-checkins@python.org Unsubscribe: http://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
