Tokio Kikuchi wrote:
>
>We may have to patch against this email package parsedate bug.
>I've just uploaded a patch on SF tracker.  Please someone review this 
>before I commit in the CVS (this weekend, maybe).

I have looked at the patch in the tracker.

Caveat: I haven't tested anything - this is just based on my reading.

I think the patch is good. The issue I see is that Scrubber.py may not
currently be doing the right thing if parsedate() returns None.

Consider the attached patch for Scrubber.py in addition to the patch in
the tracker.

-- 
Mark Sapiro <[EMAIL PROTECTED]>       The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan

--- Handlers/Scrubber.py        2006-01-28 21:22:03.000000000 -0800
+++ Handlers/Scrubber.py        2006-01-30 17:58:31.890625000 -0800
@@ -124,10 +124,11 @@
     # archives/private/<listname>/attachments/YYYYMMDD/<msgid-hash>/<files>
     # Start by calculating the date-based and msgid-hash components.
     fmt = '%Y%m%d'
+    now = None
     datestr = msg.get('Date')
     if datestr:
         now = parsedate(datestr)
-    else:
+    if not now:
         now = time.gmtime(msgdata.get('received_time', time.time()))
     datedir = safe_strftime(fmt, now)
     if not datedir:
_______________________________________________
Mailman-Developers mailing list
[email protected]
http://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=show&amp;file=faq01.027.htp

Reply via email to