On Tue, 2006-01-31 at 19:26 -0800, Mark Sapiro wrote:

> I seem to be having a lot of trouble with this. Make that
> 
>     if t and not t[7]:
>         t = t[:7] + (1,) +t[8:]

If you look at email 3.0, the 7th item returned from parsedate() and
parsedate_tz() is always 1, obviously so that the value is acceptable to
time.mktime() and time.strftime(), or None of course.

I think the right thing to do is to fix email 2.5 to behave the same
way.  This is safe because that time is documented as not being
meaningful, so we might as well make it safe <wink>.

I'd rather do that than apply the current SF patch to Mailman.  One
thing I don't like about the patch is that it calls time.strftime() to
try to catch errors and return None.  I don't think that's necessary if
we change the email package as described above.

So let's fix and release an email 2.5.7 for Mailman 2.1.8.  Even though
there are more things I'd like to fix in the email 2.5 package, I'd
rather get this out in time to integrate in Mailman 2.1.8.  I can do
that pretty quickly.

Thoughts?
-Barry

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Mailman-Developers mailing list
[email protected]
http://mail.python.org/mailman/listinfo/mailman-developers
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-developers/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=show&amp;file=faq01.027.htp

Reply via email to