>>>>> "David" == David Engster <d...@randomsample.de> writes:

David> I checked in changes which should fix those (hopefully all of
David> them).

Hi David.

I think that your patch may contain two (related) bugs:

 1- When indexing, if a file name is longer than another one, the
    former may mistakenly be understood as an extended (read: with
    flags) version of the latter.

 2- When searching, you look for "/path/to/file*" which can also
    match a file whose name starts with the one you are looking for.

Looking at my archives, I can find filenames with different lengths,
so those bugs may trigger in real life.

I have fixed the first issue (along with some minor style points) in

  http://tinyurl.com/6sdffr

I have also added a FIXME: at the appropriate place for the second
issue. If may be necessary to look for:

  - the exact file name
  - the file name with ":*" replacing the flags part if present
  - the file name without the flags part if present; I'm not sure this
    one is needed as don't know it makes sense to entirely remove
    all the existing flags

You can get this patch by doing

  git pull git://git.rfc1149.net/mairix.git for-david

Note that I haven't tested this patch so it may contain new bugs.

  Sam
-- 
Samuel Tardieu -- s...@rfc1149.net -- http://www.rfc1149.net/


------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Mairix-users mailing list
Mairix-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mairix-users

Reply via email to