On Tue, 22 Oct 2002 17:22:29 +0200, [EMAIL PROTECTED]
(Rafael Garcia-Suarez) wrote:
> Index: lib/ExtUtils/MM_Unix.pm
> ===================================================================
> --- lib/ExtUtils/MM_Unix.pm
> +++ lib/ExtUtils/MM_Unix.pm Tue Oct 22 17:09:03 2002
> @@ -2366,7 +2366,7 @@
>
> Takes a path to a file that is found by init_dirscan and returns false
> if we don't want to include this file in the library. Mainly used to
> -exclude RCS, CVS, and SCCS directories from installation.
> +exclude RCS, CVS, SCCS and Subversion directories from installation.
>
> =cut
>
Since the original sentence had a comma before 'and', I suggest the
replacement also keep that comma (hence, s/SCCS and Sub/SCCS, and Sub/).
> @@ -2374,7 +2374,7 @@
>
> sub libscan {
> my($self,$path) = @_;
> - return '' if $path =~ m:\b(RCS|CVS|SCCS)\b: ;
> + return '' if $path =~ m:(\bRCS|\bCVS|\bSCCS|\B\.svn)\b: ;
> $path;
> }
>
If you're going to move the leading \b into each alternative, why not
move the trailing \b in as well? Then each alternative looks like
\bRCS\b or \B\.svn\b and is more "self-contained". I guess it just
looked a little funny to me to abstract out only one single (no-width,
even) "character".
> Index: lib/ExtUtils/MM_MacOS.pm
> ===================================================================
> --- lib/ExtUtils/MM_MacOS.pm
> +++ lib/ExtUtils/MM_MacOS.pm Tue Oct 22 16:09:19 2002
> @@ -582,7 +582,7 @@
>
> Takes a path to a file that is found by init_dirscan and returns false
> if we don't want to include this file in the library. Mainly used to
> -exclude RCS, CVS, and SCCS directories from installation.
> +exclude RCS, CVS, SCCS and Subversion directories from installation.
>
> =cut
>
See above.
Cheers,
Philip
