On Thu, Nov 14, 2002 at 10:40:30PM -0500, Michael G Schwern wrote:
> Manifest calculations are always Unix style, so I think (^|\/)\.svn\/ is
> safe to find all .svn directories.  The RCS and CVS regexes could be done
> the same.  And oh yeah, we're supposed to be doing SCCS, too.

I decided to go with your simplier \B method.  I got lazy.


> > --- lib/ExtUtils/MANIFEST.SKIP
> > +++ lib/ExtUtils/MANIFEST.SKIP      Tue Oct 22 17:08:34 2002
> > @@ -2,6 +2,7 @@
> >  \bRCS\b
> >  \bCVS\b
> >  ,v$
> > +\B\.svn\b

Ok, a mutated version of your patch is in.

- made MM_Unix->libscan() cross-platform and more accurate by using
File::Spec->splitpath/dir to actually look at the individual parts of the
path rather than try to get away with a regex.

- moved it into MM_Any

- eliminated the MM_MacOS override

- replaced the duplicate and out-of-date regex in pm_to_blib with a call to
  libscan()

- then I added .svn files to the libscan check and the rest of your manifest
  changes.

snapshot on makemaker.org


-- 

Michael G. Schwern   <[EMAIL PROTECTED]>    http://www.pobox.com/~schwern/
Perl Quality Assurance      <[EMAIL PROTECTED]>         Kwalitee Is Job One
Sometimes you eat the path, sometimes the path eats you.

Reply via email to